Add RPC API endpoint env#156
Merged
Merged
Conversation
KaloyanTanev
approved these changes
Aug 12, 2025
OisinKyne
requested changes
Aug 12, 2025
| - CHARON_LOKI_ADDRESSES=${CHARON_LOKI_ADDRESSES:-http://loki:3100/loki/api/v1/push} | ||
| - CHARON_LOKI_SERVICE=charon | ||
| - CHARON_NICKNAME=${CHARON_NICKNAME:-} | ||
| - CHARON_EXECUTION_RPC_API_ENDPOINT=${CHARON_EXECUTION_RPC_API_ENDPOINT:-} |
There was a problem hiding this comment.
I feel like we should default to the EL right here in the stack, currently that's `
Suggested change
| - CHARON_EXECUTION_RPC_API_ENDPOINT=${CHARON_EXECUTION_RPC_API_ENDPOINT:-} | |
| - CHARON_EXECUTION_RPC_API_ENDPOINT=${CHARON_EXECUTION_RPC_API_ENDPOINT:-"http://nethermind:8545} |
also, the flag is execution-client-rpc-endpoint if the docs are right, so shouldn't it be CHARON_EXECUTION_CLIENT_RPC_ENDPOINT ?
There was a problem hiding this comment.
Also, Kalo's #149 changes this to el-nethermind so we need to change this or kalo's pr should change it after this goes in
Author
There was a problem hiding this comment.
Ah right, I looked at the (eth1) PR description but it had the flag outdated
Author
There was a problem hiding this comment.
I would prefer to push it with nethermind and then after kalo's PR rebase we change it to el-nethermind
OisinKyne
approved these changes
Aug 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
CHARON_EXECUTION_RPC_API_ENDPOINTenv